Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made status to english in role change mailer's metadata #10124

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danieljames-dj
Copy link
Member

No description provided.

@dunkOnIT
Copy link
Contributor

Why is this needed?

@danieljames-dj
Copy link
Member Author

Why is this needed?

Because in emails sometimes we are getting the status in different language - like when somebody is making the change from non-english locale.

@dunkOnIT
Copy link
Contributor

dunkOnIT commented Oct 23, 2024

Ah I see! So we're essentially telling i18n "give us this key in English, not whatever language setting the user triggering it is using"?

Any suggest on how I can reproduce this locally to test?

@danieljames-dj
Copy link
Member Author

Correct. In local you can sign in as a WST senior (basically yourself), change to non English language, go to 'New Admin Panel' and go to "/panel/admin#groups-manager-admin" and promote someone from member to non-member.

(I've commented immediately after your comment, but somehow I added my comment after editing your comment and today when I checked I see my comment under your comment and I realized the mistake, really sorry for that 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants