Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add locations screen #375

Closed
mrchrisadams opened this issue Jan 18, 2023 · 2 comments
Closed

[ENHANCEMENT] Add locations screen #375

mrchrisadams opened this issue Jan 18, 2023 · 2 comments

Comments

@mrchrisadams
Copy link
Member

Is your feature request related to a problem? Please describe.

We want to represent that a given hosting provider can be active in more than one location. Rather than jamming it into an existing form, we'd like to see if this works better as a separate step in the form wizard we are building.

Describe the solution you'd like

We would add a new step in the multi step form where users would list at least one location that their organisation is active in.

Implementation

We'd need to extend the ProviderRegistrationView with a something like a new entry in the FORMS list.

So here,

FORMS = [
        (Steps.ORG_DETAILS.value, OrgDetailsForm),
        (Steps.SERVICES.value, ServicesForm),
        (Steps.GREEN_EVIDENCE.value, GreenEvidenceForm),
        (Steps.NETWORK_FOOTPRINT.value, NetworkFootprintForm),
        (Steps.CONSENT.value, ConsentForm),
    ]

We'd have something like this, where we create a new OrgLocationForm that contains the relevant convenient formset

FORMS = [
        (Steps.ORG_DETAILS.value, OrgDetailsForm),
        (Steps.LOCATIONS.value, OrgLocationForm),
        (Steps.SERVICES.value, ServicesForm),
        (Steps.GREEN_EVIDENCE.value, GreenEvidenceForm),
        (Steps.NETWORK_FOOTPRINT.value, NetworkFootprintForm),
        (Steps.CONSENT.value, ConsentForm),
    ]

And update the templates accordingly:

TEMPLATES = {
        Steps.ORG_DETAILS.value: "provider_registration/about_org.html",
        Steps.LOCATIONS.value: "provider_registration/locations.html",
        Steps.SERVICES.value: "provider_registration/services.html",
        Steps.GREEN_EVIDENCE.value: "provider_registration/evidence.html",
        Steps.NETWORK_FOOTPRINT.value: "provider_registration/network_footprint.html",
        Steps.CONSENT.value: "provider_registration/consent.html",
    }
@tortila
Copy link
Contributor

tortila commented Jan 18, 2023

@mrchrisadams
Copy link
Member Author

Closing this as we resolved it in #378

#378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants