Is _DRIVER_TEAM_MAPPING in init.py still needed? #587
Closed
Casper-Guo
started this conversation in
General
Replies: 1 comment
-
I'd say remove it. The variable is technically is still accessed. But the whole code block that uses it isn't reached usually. It only runs if the F1 API isn't supported or has no driver info, and if Ergast has no result data as well. I think this was introduced when the livetiming API wasn't working at all and loading data from recordings was the only option. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
It is a dictionary mapping driver numbers to some basic driver information, e.g.
It is used in
core.py
for when driver data is unavailable when loading laps.The mapping is outdated. If we still rely on it then a robust solution should be pursued, if we no longer use it then it can be removed.
Beta Was this translation helpful? Give feedback.
All reactions