Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings after upgrading to v3.0.0 #8

Closed
smashercosmo opened this issue Jul 1, 2019 · 3 comments
Closed

Warnings after upgrading to v3.0.0 #8

smashercosmo opened this issue Jul 1, 2019 · 3 comments

Comments

@smashercosmo
Copy link

Started getting the following warnings after upgrading:

Warning: Unknown event handler property `onActivation`. It will be ignored.

Warning: Unknown event handler property `onDeactivation`. It will be ignored.
@theKashey
Copy link
Owner

Thank you for reporting this issue. I've found a little time bomb with hooks and will release a new version tomorrow.

The real problem behind this issue - aria-hidden is not being set, while scroll-lock and focus-lock are working as they would.
All units are working perfectly, but the integration part failed :(

@smashercosmo
Copy link
Author

Thank you. Waiting for the new release then)

@theKashey
Copy link
Owner

Done. This time I've got a test for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smashercosmo @theKashey