Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide & apply what time range query without stores should announce #1299

Closed
brancz opened this issue Jul 2, 2019 · 6 comments · Fixed by #2310
Closed

Decide & apply what time range query without stores should announce #1299

brancz opened this issue Jul 2, 2019 · 6 comments · Fixed by #2310

Comments

@brancz
Copy link
Member

brancz commented Jul 2, 2019

This is a follow up from #1284 (comment)

If a query component has no stores discovered, it currently announces that it has data from time range 0 to math.MaxInt64. @bwplotka mentioned that this should either be all of time, which would be math.MinInt64 to math.MaxInt64 or nothing, which could be represented as math.MaxInt64 to math.MaxInt64.

I think either of those two make more sense than what we currently have, but I'm tending towards the latter, to not do unneeded requests to a store.

@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 11, 2020
@brancz brancz removed the stale label Jan 13, 2020
@stale
Copy link

stale bot commented Feb 12, 2020

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

@stale stale bot added the stale label Feb 12, 2020
@brancz brancz removed the stale label Feb 13, 2020
@brancz
Copy link
Member Author

brancz commented Feb 13, 2020

We have yet to decide on this.

@stale
Copy link

stale bot commented Mar 14, 2020

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

@stale stale bot added the stale label Mar 14, 2020
@bwplotka bwplotka changed the title Decide what time range query without stores should announce Decide & apply what time range query without stores should announce Mar 14, 2020
@stale stale bot removed the stale label Mar 14, 2020
@bwplotka
Copy link
Member

I like or nothing, which could be represented as math.MaxInt64 to math.MaxInt64 but maybe in form or [0:0] It is just more readable for humans... WDYT?

@brancz
Copy link
Member Author

brancz commented Mar 24, 2020

Happy with 0, 0. Will do a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants