Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

We really should add rollup support #269

Open
yaronyg opened this issue Jun 6, 2016 · 2 comments
Open

We really should add rollup support #269

yaronyg opened this issue Jun 6, 2016 · 2 comments

Comments

@yaronyg
Copy link
Member

yaronyg commented Jun 6, 2016

The NPM rollup project can take a whole mess of separate node.js files and roll them up into one monster file. This would help Thali in a bunch of ways including making loading apps faster since we wouldn't have the zip file processing overhead. Since we don't have a lot of optional code everything we have is more or less guaranteed to be loaded so this could help us. It's at least worth testing out.

What makes rollup really cool over says browserify is that it actually analyzes dependencies and just pulls in the code they need. This means that we could potentially radically reduce our footprint in the app since we have tons of dependencies where we aren't coming close to using everything they do.

To make this work we would have to switch to ES6 modules but we were anyway planning on moving to Typescript which already supports ES6 modules so we would be good.

@mohlsen
Copy link
Member

mohlsen commented Jun 6, 2016

Interesting project. I still own you a blog post on how we are trying to minimize this (deleting files basically). Wonder how this project work with native node_modules modules mixed in. I see a few issues related to them in their repo issue list.

@yaronyg
Copy link
Member Author

yaronyg commented Jun 6, 2016

I haven't really had a chance to investigate. But PouchDB uses them and they have an optional dependency on leveldown so one figures it can be made to work.

@yaronyg yaronyg added this to the V1 milestone Aug 3, 2016
@yaronyg yaronyg removed this from the V1 milestone Aug 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants