Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock should use @jest/globals #458

Closed
trajano opened this issue Dec 4, 2023 · 1 comment
Closed

Mock should use @jest/globals #458

trajano opened this issue Dec 4, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@trajano
Copy link
Contributor

trajano commented Dec 4, 2023

https://github.com/th3rdwave/react-native-safe-area-context/blob/main/jest/mock.tsx has an implied jest it should use @jest/globals as per https://jestjs.io/docs/getting-started#type-definitions as per the note about it

@types/jest is a third party library maintained at DefinitelyTyped, hence the latest Jest features or versions may not be covered yet. Try to match versions of Jest and @types/jest as closely as possible. For example, if you are using Jest 27.4.0 then installing 27.4.x of @types/jest is ideal.
@jacobp100 jacobp100 added the help wanted Extra attention is needed label Dec 4, 2023
@jacobp100
Copy link
Collaborator

Fancy doing a PR?

@trajano trajano mentioned this issue Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trajano @janicduplessis @jacobp100