Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canyon Hard Fork] Fix EIP1559DenominatorCanyon config field name #27

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

ImTei
Copy link
Member

@ImTei ImTei commented Nov 7, 2023

We must use the same config name and json key as op-geth.

@ImTei ImTei requested a review from pcw109550 November 7, 2023 08:02
@pcw109550 pcw109550 changed the title Fix EIP1559DenominatorCanyon config field name [Canyon Hard Fork] Fix EIP1559DenominatorCanyon config field name Nov 7, 2023
Copy link
Member

@pcw109550 pcw109550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For our reference, this code diff was also introduced at ethereum-optimism/op-geth#171.

@ImTei ImTei merged commit daea839 into tip/canyon Nov 8, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants