feat!: rewrite userEvent.clear API
#779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: An error is thrown when calling `userEvent.clear` on an element which is not editable. BREAKING CHANGE: An error is thrown when event handlers prevent `userEvent.clear` from focussing/selecting content.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f6ae1a0:
|
Codecov Report
@@ Coverage Diff @@
## alpha #779 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 65 65
Lines 1385 1403 +18
Branches 546 549 +3
=========================================
+ Hits 1385 1403 +18
Continue to review full report at Codecov.
|
5 tasks
|
🎉 This PR is included in version 14.0.0-alpha.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ph-fritsche
added a commit
that referenced
this pull request
Nov 28, 2021
BREAKING CHANGE: An error is thrown when calling `userEvent.clear` on an element which is not editable. BREAKING CHANGE: An error is thrown when event handlers prevent `userEvent.clear` from focussing/selecting content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: An error is thrown when calling
userEvent.clearon an element which is not editable.BREAKING CHANGE: An error is thrown when event handlers prevent
userEvent.clearfrom focussing/selecting content.What:
Rewrite implementation of
userEvent.clear().Add support for contenteditable.
Add support for UI input when selection stretches over multiple elements.
Why:
Closes #778
How:
deleteContentBackwardChecklist:
Additional informations
This PR unblocks the removing of
{selectall}which is the only descriptor not translating to a key.