Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(click): focus closest focusable (#566) #567

Merged
merged 2 commits into from
Feb 28, 2021
Merged

fix(click): focus closest focusable (#566) #567

merged 2 commits into from
Feb 28, 2021

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented Feb 28, 2021

What:

Focus closest focusable ancestor of the clicked element.

Why:

See #566

How:

Only blur() if the clicked element does not have a focusable ancestor.

Checklist:

  • n/a Documentation
  • Tests
  • n/a Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #567 (b659368) into master (7a5c51e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #567   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          699       706    +7     
  Branches       221       222    +1     
=========================================
+ Hits           699       706    +7     
Impacted Files Coverage Δ
src/click.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5c51e...b659368. Read the comment docs.

@ph-fritsche
Copy link
Member Author

@just-boris

Copy link

@just-boris just-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also downloaded the patch and tested inside our project. The fix resolves our original issue

@ph-fritsche ph-fritsche merged commit 73c2323 into master Feb 28, 2021
@ph-fritsche ph-fritsche deleted the fix-566 branch February 28, 2021 12:11
@github-actions
Copy link

🎉 This PR is included in version 12.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants