Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to remove toBeInTheDOM #140

Closed
kentcdodds opened this issue Jul 18, 2018 · 3 comments
Closed

Update docs to remove toBeInTheDOM #140

kentcdodds opened this issue Jul 18, 2018 · 3 comments
Labels
documentation A docs improvement is needed. help wanted Extra attention is needed

Comments

@kentcdodds
Copy link
Member

Regarding the deprecation of toBeInTheDOM we should either find better assertions or use toBeInTheDocument: testing-library/jest-dom#40

Anyone wanna try that?
@kentcdodds kentcdodds added help wanted Extra attention is needed documentation A docs improvement is needed. labels Jul 18, 2018
@gnapse
Copy link
Member

gnapse commented Jul 19, 2018

I'd like to.

BTW, it's not just the readme, there's a test using toBeInTheDOM. And this PR would also need to upgrade the jest-dom version (especially in the case where changing stuff involves needing to use toBeInTheDocument) right?

@kentcdodds
Copy link
Member Author

Good point. Yes, we'll want to upgrade things 👍

@gnapse gnapse mentioned this issue Jul 19, 2018
Closed
@kentcdodds
Copy link
Member Author

🎉 This issue has been resolved in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation A docs improvement is needed. help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnapse @kentcdodds