fix: Support @starting-style #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnapse
approved these changes
Jun 10, 2024
|
@all-contributors please add @jantimon for bug |
|
I've put up a pull request to add @jantimon! 🎉 |
This was referenced Sep 6, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Upgraded the
@adobe/css-toolsdependency to include the fix for parsing the@starting-styleCSS feature, which was causing amissing '}'error.Why:
The current version of
@adobe/css-toolsused bytesting-library/jest-domfails to parse the@starting-styleCSS feature, resulting in a parsing error. The upgrade includes a fix for this issue, allowing for the correct parsing of CSS files using@starting-style.How:
The changes were implemented by updating the
package.jsonfile to use the latest version of@adobe/css-toolswhich includes the fix from the PR I submitted to@adobe/css-tools(adobe/css-tools#323).Checklist:
jsdomandCSSOMupdates)Additional Comments:
Unfortunately, I could not add a test case for the
@starting-stylefeature becausejsdom 20uses CSSOM 0.6.0 for CSS parsing, which also has a similar issue.I fixed that already in this PR (rrweb-io/CSSOM#1), but the latest version of
jsdomcannot be merged intojest. See jestjs/jest#14846 (comment) for details