Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace text example of private key with an image in the jenkins readme #1027

Conversation

daniel-cit
Copy link
Contributor

@daniel-cit daniel-cit commented Nov 14, 2023

This PR replaces the text example of a RSA private key with an image in the Jenkins readme to prevent.

This example of a RSA private key may trigger a validation when pushing code to source repo to prevent exposure of private keys.

fixes #1014

@daniel-cit daniel-cit requested review from rjerrems, gtsorbo and a team as code owners November 14, 2023 18:28
@daniel-cit
Copy link
Contributor Author

/gcbrun

@daniel-cit
Copy link
Contributor Author

@gtsorbo this Pull request is documentation only.
The reason the integration build is triggered is because the png file add is not in the exclusion list of file formats

@apeabody
Copy link
Contributor

apeabody commented Dec 8, 2023

@gtsorbo this Pull request is documentation only. The reason the integration build is triggered is because the png file add is not in the exclusion list of file formats

If someone opens a PR for the trigger exclusion I can review it: https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/master/infra/terraform/test-org/ci-triggers/triggers.tf#L422

@gtsorbo
Copy link
Collaborator

gtsorbo commented Dec 8, 2023

@gtsorbo this Pull request is documentation only. The reason the integration build is triggered is because the png file add is not in the exclusion list of file formats

If someone opens a PR for the trigger exclusion I can review it: https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/master/infra/terraform/test-org/ci-triggers/triggers.tf#L422

GoogleCloudPlatform/cloud-foundation-toolkit#2028 for your consideration @apeabody

@apeabody
Copy link
Contributor

apeabody commented Dec 8, 2023

@gtsorbo this Pull request is documentation only. The reason the integration build is triggered is because the png file add is not in the exclusion list of file formats

If someone opens a PR for the trigger exclusion I can review it: https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/master/infra/terraform/test-org/ci-triggers/triggers.tf#L422

GoogleCloudPlatform/cloud-foundation-toolkit#2028 for your consideration @apeabody

Thanks! I've merged GoogleCloudPlatform/cloud-foundation-toolkit#2027 and applied the update to the triggers.

@gtsorbo gtsorbo merged commit 325785c into terraform-google-modules:master Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0-bootstrap gcp-bootstrap Step 16 Fails
4 participants