fix: Add explicit parameters for S3 interface endpoint #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the existing S3 endpoint parameters purely for the gateway type and adds new parameters for the S3 interface type. The existing parameters that don't make sense for a gateway endpoint are removed as well as the parameter for choosing the type. The missing outputs are also added for parity with existing endpoints. Based on the work in terraform-aws-modules#575. Fixes terraform-aws-modules#603
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the existing S3 endpoint parameters purely for the gateway type and adds new parameters for the S3 interface type. The existing parameters that don't make sense for a gateway endpoint are removed as well as the parameter for choosing the type.
The missing outputs are also added for parity with existing endpoints.
Based on the work in #575.
Motivation and Context
The current module only allows either an interface or gateway endpoint however it's valid to have both types configured.
Fixes #603
Breaking Changes
Yes, sadly. It makes sense to keep the default endpoint type to be a gateway as that was first. Because new parameters are added explicitly for the new interface endpoint type, there are some parameters that now no longer make sense for gateway endpoint types (private DNS, subnet ID's, etc.). You could keep some of the current names however the parameter naming would be confusing and not follow the consistency and conventions of the other parameters in the module.
How Has This Been Tested?
I will update the tests shortly.