fix: Update flow log ARNs to use partition from aws_partition data source #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ensuring compatibility with AWS GovCloud and other partitions tfdocs
pjaudiomv
changed the title
bryantbiggs
approved these changes
Aug 9, 2024
bryantbiggs
merged commit 72cde38
into
terraform-aws-modules:master
21 of 22 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Aug 9, 2024
## [5.12.1](v5.12.0...v5.12.1) (2024-08-09) ### Bug Fixes * Update flow log ARNs to use partition from aws_partition data source ([#1112](#1112)) ([72cde38](72cde38))
|
This PR is included in version 5.12.1 🎉 |
|
Thank you for quick review and release |
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ensuring compatibility with AWS GovCloud and other partitions
Description
Update flow log ARNs to use partition from aws_partition data source, ensuring compatibility with AWS GovCloud and other partitions. This was due to the least privilege change in 5.12.0, 5.11.0 and earlier are fine. See PR #1088
Motivation and Context
Currently when deploying to GovCloud with flow logs you get the following error
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request