feat: Add support for ip_address_type for VPC endpoint
#1096
Conversation
|
This PR has been automatically marked as stale because it has been open 30 days |
examples/ipv6-dualstack/main.tf
Outdated
| @@ -47,3 +47,36 @@ module "vpc" { | |||
|
|
|||
| tags = local.tags | |||
| } | |||
|
|
|||
| module "vpc_endpoints" { | |||
There was a problem hiding this comment.
we don't need a new example - we can use an existing example
There was a problem hiding this comment.
hi @bryantbiggs , I have a question,
as an example - ipv6 VPC endpoints can be created without subnets attached. But as a good example - probably better to add a fully working example. If the second option is preferable - we need to add ipv6 subnets to the VPC setup. Something like that:
athena = {
service = "athena"
ip_address_type = "dualstack"
subnet_ids = [ipv6_subnet1, ipv6_subnet2. ipv6_subnet3]
tags = { Name = "athena-vpc-endpoint" }
},
What do you think about this ?
There was a problem hiding this comment.
apologies, I don't understand the question - what are you asking?
There was a problem hiding this comment.
sorry, let me rephrase with details
I can add this minimal example, which will create the endpoint but it will not work because subnets are not defined
lakeformation = {
service = "lakeformation"
ip_address_type = "ipv6"
tags = { Name = "lakeformation-vpc-endpoint" }
}
or add an example like this, which is not correct, because module.vpc.private_subnets returns all subnets (ipv4 and ipv6), but not only ipv6
lakeformation = {
service = "lakeformation"
ip_address_type = "ipv6"
subnet_ids = module.vpc.private_subnets
tags = { Name = "lakeformation-vpc-endpoint" }
},
so the question is - what do you think, is there any good workaround ?
There was a problem hiding this comment.
got it - we can forgo updating the example for this, its just adding one argument thats a direct pass through, not much to test/validate/demonstrate
There was a problem hiding this comment.
Removed the example
bryantbiggs
changed the title
ip_address_type for VPC endpoint
## [5.13.0](v5.12.1...v5.13.0) (2024-08-16) ### Features * Add support for `ip_address_type` for VPC endpoint ([#1096](#1096)) ([d868303](d868303))
|
This PR is included in version 5.13.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Added parameter ip_address_type to allow ipv4. ipv6 and dualstack ip_address_type support
Motivation and Context
To solve issue #1091
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request