Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ca_cert_identifier option #83

Merged
merged 5 commits into from
Nov 28, 2019
Merged

add support for ca_cert_identifier option #83

merged 5 commits into from
Nov 28, 2019

Conversation

koneru9999
Copy link

Description

This PR adds the option to set the ca_cert_identifier
As the current CA is expiring 5th March 2020 i need to update my clusters to use the new CA before that. The default is currently set to the old one to not break any existing installations.

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL-certificate-rotation.html

Terraform has recently added support for this. hashicorp/terraform-provider-aws#10490

main.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko merged commit 0411b1a into terraform-aws-modules:terraform011 Nov 28, 2019
@antonbabenko
Copy link
Member

v1.20.0 has been just released.

Thank you @koneru9999 !

@jjuarez
Copy link

jjuarez commented Nov 28, 2019

is this integrated for the Terraform 0.11 branch too?

@antonbabenko
Copy link
Member

Yes, Terraform 0.11 users should use v1.20.0 of this module.

@jjuarez
Copy link

jjuarez commented Nov 28, 2019

It seems like not working our case we're facing the error:

Error: module.pre-aurora-01.aws_rds_cluster.this: : invalid or unknown key: ca_cert_identifier

using the v1.20.0 for the terraform 0.11, this makes no sense, new variable with default...
terraform 0.11.14
Providers:

  • "null" (1.0.0)...
  • "aws" (2.40.0)...
  • "random" (2.2.1)...

@antonbabenko
Copy link
Member

v1.21.0 has been just released where this is fixed.

I used to believe that people opening pull-requests verify the changes, I was wrong.

RDS Aurora simply does not support ca_cert_identifier option.

Big thanks @jjuarez for your feedback!

@koneru9999
Copy link
Author

@antonbabenko My apologies for the PR and wasting your valuable time. I could have checked it more properly. 😞

@koneru9999 koneru9999 deleted the patch-1 branch November 28, 2019 23:28
@antonbabenko
Copy link
Member

@koneru9999 That's ok, it happens sometimes. For me, it means that the simplest automatic checks would catch this error. I probably need to prioritize those a bit more. :)

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants