-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added conditional creation of RDS Aurora cluster #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
antonbabenko
commented
Oct 30, 2020
- Added create_security_group input variable.
- Ensure aws_iam_role and aws_iam_role_policy_attachment do not get created if create_cluster is false.
- Update readme with conditional creation note for create_cluster use.
…ated if create_cluster is false.
…te_cluster_input_var
antonbabenko
changed the title
pr103 conditional creation
feat: Added conditional creation of RDS Aurora cluster
Oct 30, 2020
Thanks @shanedroid ! v2.29.0 has been just released. |
This was referenced Oct 30, 2020
tomasbackman
pushed a commit
to qapital/terraform-aws-rds-aurora
that referenced
this pull request
Nov 16, 2020
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.