Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for replace_security_groups_on_destroy and replacement_security_group_ids #418

Closed
ricoli opened this issue Feb 10, 2023 · 4 comments

Comments

@ricoli
Copy link
Contributor

ricoli commented Feb 10, 2023

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Is your request related to a problem? Please describe.

Yes - destroying VPC associated lambdas taking a long time because of waiting for the security group(s) to no longer be used by the ENIs. See hashicorp/terraform-provider-aws#10329 (comment) for details

Describe the solution you'd like.

Support for the newly introduced replace_security_groups_on_destroy and replacement_security_group_ids lambda function arguments

Describe alternatives you've considered.

Additional context

@antonbabenko
Copy link
Member

Good idea! PR is welcome.

@ricoli
Copy link
Contributor Author

ricoli commented Feb 13, 2023

Good idea! PR is welcome.

Sure, here you go: #422

@ricoli
Copy link
Contributor Author

ricoli commented Mar 9, 2023

Good idea! PR is welcome.

Sure, here you go: #422

@antonbabenko any chance my PR could get a review please?

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants