Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove empty string elements from local.urls in iam-assumable-role-with-oidc submodule #99

Conversation

yukin01
Copy link
Contributor

@yukin01 yukin01 commented Oct 27, 2020

Description

Remove empty string elements from local.urls in iam-assumable-role-with-oidc submodule.

Motivation and Context

If only var.provider_urls is specified and var.provider_url is not specified, the array will contain an empty character and an error will occur.

Breaking Changes

No.

How Has This Been Tested?

Execute terraform plan as follows.

module "iam_assumable_role_admin" {
  source  = "terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc"
  version = "2.22.0"

  create_role   = true
  role_name     = "role-with-oidc"
  provider_urls = ["oidc.eks.eu-west-1.amazonaws.com/id/AA9E170D464AF7B92084EF72A69B9DC8"]
  role_policy_arns = [
    "arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy",
  ]
  oidc_fully_qualified_subjects = ["system:serviceaccount:default:sa1", "system:serviceaccount:default:sa2"]
}

@yukin01 yukin01 changed the title Remove empty string elements from local.urls fix: remove empty string elements from local.urls Oct 27, 2020
@antonbabenko antonbabenko changed the title fix: remove empty string elements from local.urls fix: remove empty string elements from local.urls in iam-assumable-role-with-oidc submodule Oct 30, 2020
@antonbabenko antonbabenko merged commit 2b44477 into terraform-aws-modules:master Oct 30, 2020
@antonbabenko
Copy link
Member

Good catch, @yukin01 !

v2.25.0 has been just released.

@yukin01 yukin01 deleted the fix/iam-assumable-role-with-oidc branch November 20, 2020 08:17
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants