Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instance profile to iam-assumable-role #46

Merged

Conversation

alemairebe
Copy link
Contributor

Description

I added the possibility to create an IAM instance profile to "iam-assumable-role" As it only takes 1 extra parameter, and is whitin the scope of this module (IAM)

@dmattia
Copy link

dmattia commented Feb 11, 2020

I was just about to make this PR, glad I checked first! Thanks for doing this @alemairebe

Could you please rebase?

@antonbabenko antonbabenko merged commit 9006610 into terraform-aws-modules:master Feb 22, 2020
@antonbabenko
Copy link
Member

Thanks @alemairebe for this addition!

v2.7.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants