Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct TG for listeners for Terraform 0.11 (fixed #119) #121

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Set correct TG for listeners for Terraform 0.11 (fixed #119) #121

merged 3 commits into from
Nov 20, 2019

Conversation

aidan-melen
Copy link
Contributor

@aidan-melen aidan-melen commented Oct 3, 2019

PR o'clock

When you specify two ALB listeners (http-80 and http-8080) and two Target Groups (tg-80 and tg-8080), you get the following mapping:

http-80 -> tg-80
http-8080 -> tg-80

and instead of the expected:

http-80 -> tg-80
http-8080 -> tg-8080

Please explain the changes you made here and link to any relevant issues.

Checklist

  • terraform fmt and terraform validate both work from the root and examples/alb_test_fixture directories (look in CI for an example)
  • Tests for the changes have been added and passing (for bug fixes/features)
  • Test results are pasted in this PR (in lieu of CI)
  • Docs have been added/updated (for bug fixes/features)
  • Any breaking changes are noted in the description above

@aidan-melen
Copy link
Contributor Author

related to: #119

@aidan-melen
Copy link
Contributor Author

the travis-ci is failing is complete unrealted to my changes. the CI/CD test environment looks missconfigured the the aws provider region:

$$$$$$ Running command `terraform destroy -force -lock=true -lock-timeout=0s -input=false  -parallelism=10 -refresh=true   /home/travis/build/terraform-aws-modules/terraform-aws-alb/examples/alb_test_fixture`

       

       Error: Error refreshing state: 1 error(s) occurred:

       

       * provider.aws: Invalid AWS Region: 

       

       

-----> Destroying <default-aws>...

$$$$$$ Running command `terraform init -input=false -lock=true -lock-timeout=0s  -force-copy -backend=true  -get=true -get-plugins=true  -verify-plugins=true /home/travis/build/terraform-aws-modules/terraform-aws-alb/examples/alb_test_fixture`

       Initializing modules...

       - module.vpc

       - module.security_group

       - module.alb

       

       Initializing provider plugins...

       

       Terraform has been successfully initialized!

$$$$$$ Running command `terraform workspace select kitchen-terraform-default-aws`

$$$$$$ Running command `terraform destroy -force -lock=true -lock-timeout=0s -input=false  -parallelism=10 -refresh=true   /home/travis/build/terraform-aws-modules/terraform-aws-alb/examples/alb_test_fixture`

       

       Error: Error refreshing state: 1 error(s) occurred:

       

       * provider.aws: Invalid AWS Region: 

       ```

@aidan-melen
Copy link
Contributor Author

@brandoconnor do you have any idea why the CI/CD is running this way?

@antonbabenko antonbabenko changed the title fixed issue 119 Set correct TG for listeners for Terraform 0.11 (fixed #119) Nov 20, 2019
@antonbabenko antonbabenko merged commit 8d558c1 into terraform-aws-modules:terraform011 Nov 20, 2019
@antonbabenko
Copy link
Member

v3.7.0 of this module has been just released for Terraform 0.11 users.

Thank you again, @aidan-melen !

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants