Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout testcases #25

Merged
merged 1 commit into from
May 17, 2019
Merged

Checkout testcases #25

merged 1 commit into from
May 17, 2019

Conversation

hhsecond
Copy link
Member

@hhsecond hhsecond commented May 2, 2019

Description

Test cases & name validity check for the branch name

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member Author

@hhsecond hhsecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlizzo I would like to hear your thoughts in a couple of cases and hence keeping it incomplete. Would be great if you can review the #TODOs and we can take it from there

src/hangar/repository.py Outdated Show resolved Hide resolved
@hhsecond hhsecond requested a review from rlizzo May 2, 2019 10:55
@hhsecond hhsecond changed the title Checkout testcases & name validity check for branch name Checkout testcases May 2, 2019
@hhsecond hhsecond added WIP Don't merge; Work in Progress and removed PR In Progress labels May 2, 2019
Copy link
Member

@rlizzo rlizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, these are fairly well thought out tests for the basics of working with checkout and merge commits. A few comments are left below, but nothing major aside from one or two of the (potential) bugs you've found (nice job catching them btw!)

Nice work sherin, much appreciated!

src/hangar/repository.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_checkout.py Outdated Show resolved Hide resolved
tests/test_checkout.py Outdated Show resolved Hide resolved
tests/test_checkout.py Outdated Show resolved Hide resolved
tests/test_checkout.py Outdated Show resolved Hide resolved
tests/test_checkout.py Outdated Show resolved Hide resolved
tests/test_checkout.py Show resolved Hide resolved
tests/test_checkout.py Show resolved Hide resolved
tests/test_checkout.py Show resolved Hide resolved
@rlizzo rlizzo mentioned this pull request May 6, 2019
9 tasks
tests/conftest.py Outdated Show resolved Hide resolved
@rlizzo
Copy link
Member

rlizzo commented May 17, 2019

So I'm a bit confused as to the status of this? I think there's a lot of overlap with #32, and this branch doesn't seem like it's really kept up with the changes in master.

Do you want to continue with this PR? Or include the relevant changes in #32 along with a most focused commit for the remainder?

@hhsecond
Copy link
Member Author

The TODOs in this PR is not just related to #32. There are few other changes that we haven't looked into at all. So I would say, let's merge this and then along with rebasing #32, will sort out what's required there. Once #32 lands, we'll have a stable master on which I can do a clean up perhaps.

@rlizzo
Copy link
Member

rlizzo commented May 17, 2019

Ok sounds good. I'm just going to rerun the tests to make sure everything is OK, then will merge this and rebase #32.

@rlizzo rlizzo merged commit 3bc0364 into tensorwerk:master May 17, 2019
@hhsecond hhsecond deleted the checkout_tests branch May 17, 2019 10:54
@hhsecond hhsecond removed the WIP Don't merge; Work in Progress label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants