-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove symlink of backend data files #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and store locations
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 95.28% 95.23% -0.05%
==========================================
Files 66 66
Lines 11878 11862 -16
Branches 1029 1011 -18
==========================================
- Hits 11317 11296 -21
+ Misses 374 370 -4
- Partials 187 196 +9
|
rlizzo
force-pushed
the
remove-symlinks
branch
from
December 4, 2019 06:53
08089ca
to
71e186e
Compare
rlizzo
changed the title
WIP: Remove symlink of backend data files
Remove symlink of backend data files
Dec 4, 2019
rlizzo
added
Awaiting Review
Author has determined PR changes area nearly complete and ready for formal review.
and removed
WIP
Don't merge; Work in Progress
labels
Dec 4, 2019
@hhsecond please review. |
hhsecond
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than minor changes with Path, looks good
rlizzo
force-pushed
the
remove-symlinks
branch
from
December 4, 2019 16:07
dae4c2e
to
57ef37e
Compare
removed unused lazyimport func
rlizzo
force-pushed
the
remove-symlinks
branch
from
December 4, 2019 16:54
57ef37e
to
30a9b5f
Compare
rlizzo
added
Resolved
and removed
Awaiting Review
Author has determined PR changes area nearly complete and ready for formal review.
labels
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required? What problem does it solve?:
Remove symlink of data files between stage, store, and remote holding directories. This is both a confusing practice, and incompatible with privileges on some platforms (google colab connected to a mounted drive).
If it fixes an open issue, please link to the issue here:
Description
Describe your changes in detail:
replace symlink data files with touched files in same staging, remote and store locations.
At time of writing, am not 100% certain this won't break backwards compatibility with 0.4 symlinks. It shouldn't (since general structure and naming conventions are honored) but need tests to prove it.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Is this PR ready for review, or a work in progress?
How Has This Been Tested?
Put an
x
in the boxes that apply:Checklist: