Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hash type codes #165

Merged
merged 4 commits into from
Nov 21, 2019
Merged

Conversation

rlizzo
Copy link
Member

@rlizzo rlizzo commented Nov 21, 2019

Motivation and Context

Why is this change required? What problem does it solve?:

Add type codes for hashes used to calculate data hash digests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

  • Ready for review
  • Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

  • Current tests cover modifications made
  • New tests have been added to the test suite
  • Modifications were made to existing tests to support these changes
  • Tests may be needed, but they are not included when the PR was proposed
  • I don't know. Help!

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have signed (or will sign when prompted) the tensorwork CLA.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rlizzo rlizzo added the Awaiting Review Author has determined PR changes area nearly complete and ready for formal review. label Nov 21, 2019
@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #165 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   95.14%   95.16%   +0.02%     
==========================================
  Files          65       66       +1     
  Lines       11831    11878      +47     
  Branches     1024     1029       +5     
==========================================
+ Hits        11256    11303      +47     
- Misses        384      385       +1     
+ Partials      191      190       -1
Impacted Files Coverage Δ
tests/test_commit_ref_verification.py 100% <ø> (ø) ⬆️
src/hangar/records/parsing.py 98.52% <100%> (+0.02%) ⬆️
tests/property_based/test_pbb_valid_hash_tcodes.py 100% <100%> (ø)
tests/property_based/test_pbt_arrayset.py 100% <100%> (ø) ⬆️
src/hangar/cli/cli.py 89.52% <100%> (ø) ⬆️
tests/test_remote_serialize.py 100% <100%> (ø) ⬆️
src/hangar/remote/server.py 77.47% <100%> (+0.18%) ⬆️
src/hangar/records/commiting.py 89.92% <100%> (ø) ⬆️
tests/test_dataloaders.py 98.88% <100%> (ø) ⬆️
src/hangar/records/hashmachine.py 100% <100%> (ø) ⬆️
... and 6 more

@rlizzo rlizzo force-pushed the add-hash-code-type-to-records branch from 1b9403b to c1f03c3 Compare November 21, 2019 13:24
@rlizzo rlizzo force-pushed the add-hash-code-type-to-records branch from c1f03c3 to d08d188 Compare November 21, 2019 15:56
@tensorwerk tensorwerk deleted a comment from lgtm-com bot Nov 21, 2019
@rlizzo rlizzo force-pushed the add-hash-code-type-to-records branch 4 times, most recently from cda14a6 to 238b87a Compare November 21, 2019 17:49
@rlizzo rlizzo force-pushed the add-hash-code-type-to-records branch from 238b87a to 2b0e89c Compare November 21, 2019 18:03
@rlizzo rlizzo force-pushed the add-hash-code-type-to-records branch from df010e7 to 92d0880 Compare November 21, 2019 18:19
@rlizzo rlizzo merged commit 730dac6 into tensorwerk:master Nov 21, 2019
@rlizzo rlizzo deleted the add-hash-code-type-to-records branch December 5, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review Author has determined PR changes area nearly complete and ready for formal review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant