Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Data Tutorial #113

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Remote Data Tutorial #113

merged 2 commits into from
Aug 19, 2019

Conversation

rlizzo
Copy link
Member

@rlizzo rlizzo commented Aug 19, 2019

Motivation and Context

Why is this change required? What problem does it solve?:

Tutorial / documentation update

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

  • Ready for review
  • Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

  • Current tests cover modifications made
  • New tests have been added to the test suite
  • Modifications were made to existing tests to support these changes
  • Tests may be needed, but they are not included when the PR was proposed
  • I don't know. Help!

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have signed (or will sign when prompted) the tensorwork CLA.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #113 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage    91.9%   91.89%   -0.01%     
==========================================
  Files          50       50              
  Lines        8757     8757              
  Branches      876      876              
==========================================
- Hits         8048     8047       -1     
- Misses        519      520       +1     
  Partials      190      190
Impacted Files Coverage Δ
src/hangar/remotes.py 89.14% <ø> (ø) ⬆️
src/hangar/backends/hdf5_00.py 86.54% <0%> (-0.38%) ⬇️

@rlizzo rlizzo merged commit a51509e into tensorwerk:master Aug 19, 2019
This was referenced Aug 19, 2019
@rlizzo rlizzo deleted the remote-tutorial branch November 11, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant