-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building of tfx-bsl on mac arm64 machines #73
Allow building of tfx-bsl on mac arm64 machines #73
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
fa2e19b
to
83e2f37
Compare
7d1fcd7
to
6dc304a
Compare
Thanks for the contribution! How did you test this? did you build from source & run the tests? Could you also please drop a line in release notes saying that there's partial support for building from source on mac arm64 machines. |
6dc304a
to
0a0e90a
Compare
Hi @iindyk , thank you for looking at this. Have now added to
Specifically:
Happy to run additional tests locally, or if I can help with getting the testing infra setup on arm64 going. |
Thanks @tangm! I'd be happy to get any help in the infra setup but unfortunately it's going to be all about internal VMs and resource allocations. |
RELEASE.md
Outdated
@@ -25,6 +25,7 @@ | |||
|
|||
## Bug Fixes and Other Changes | |||
|
|||
* Partial support for building from source on macOS arm64 machines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this under Current Version
(~line 9)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my bad. Done.
0a0e90a
to
13f1f0e
Compare
Hey, thanks for this. Any plans for new version cut on PyPI with new GitHub tag? @iindyk |
Unfortunately, we don't have releasing and test infra set up for this build. So the only way to get a mac arm64-compatible wheel at the moment is to build from source. |
Sorry, I didn't mean just for this one. I was wondering if there will be any |
there's a minor release planned in a ~ week |
Building on Apple silicon causes an error due to headers for avx-specific instructions being included for arrow. This commit adds an exclusion on avx* files from arrow when building on mac arm64.
Fixes #48
Not very familiar with Bazel or the project itself, but keen to get tfx working on apple silicon. Happy to work on this to get it through.