Remove outer function wrapper #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We remove the outer function wrapper from the default value for xComponentsCreationMethod because `vz_line_chart.stepX` is already a valid value for the property. Creating a function that returns `vz_line_chart.stepX` results in a bug.
nfelt
approved these changes
Jan 24, 2018
nfelt
pushed a commit
to nfelt/tensorboard
that referenced
this pull request
Feb 7, 2018
We remove the outer function wrapper from the default value for xComponentsCreationMethod because `vz_line_chart.stepX` is already a valid value for the property. Creating a function that returns `vz_line_chart.stepX` results in a bug.
nfelt
pushed a commit
that referenced
this pull request
Feb 7, 2018
We remove the outer function wrapper from the default value for xComponentsCreationMethod because `vz_line_chart.stepX` is already a valid value for the property. Creating a function that returns `vz_line_chart.stepX` results in a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the outer function wrapper from the default value for xComponentsCreationMethod because
vz_line_chart.stepXis already a valid value for the property. Creating a function that returnsvz_line_chart.stepXresults in a bug.This fixes an internal issue.