Make scalars is_active short circuit if apt #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the `is_active` method of the scalars plugin short-circuit if it discovers that any run has at least 1 relevant tag. This change preserves existing behavior, so there are no changes to tests (which check for the preservation of behavior). Test plan: Start TensorBoard pointed at the scalars demo data. Note that the scalars plugin loads. Start TensorBoard pointed at the PR curves demo data. The scalars plugin is inactive. Use `time.time()` to log the time it takes for some internal events file (with over 30K tags in one specific run) with and without this change. With this change, the scalars dashboard takes 0.0s to load. Without this change, it takes 12.0s. Sometimes, the frontend won't load because `is_active` takes too long to respond. Granted, one might reason that a user should not have 30K tags ... but even so, that should not block the rest of TensorBoard from loading.
nfelt
approved these changes
Oct 5, 2017
| if not self._multiplexer: | ||
| return False | ||
|
|
||
| mapping = self._multiplexer.PluginRunToTagToContent(metadata.PLUGIN_NAME) |
There was a problem hiding this comment.
nit: images_plugin.py just does this, which is a little more concise? Or do you think that's too inscrutable?
return bool(self._multiplexer.PluginRunToTagToContent(metadata.PLUGIN_NAME))
There was a problem hiding this comment.
Awesome and concise. Lets use it. I verified that it exhibits short-circuiting behavior.
chihuahua
commented
Oct 5, 2017
| if not self._multiplexer: | ||
| return False | ||
|
|
||
| mapping = self._multiplexer.PluginRunToTagToContent(metadata.PLUGIN_NAME) |
There was a problem hiding this comment.
Awesome and concise. Lets use it. I verified that it exhibits short-circuiting behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
is_activemethod of the scalars pluginshort-circuit if it discovers that any run has at least 1 relevant tag.
This change preserves existing behavior, so there are no changes to
tests (which check for the preservation of behavior).
Test plan: Start TensorBoard pointed at the scalars demo data. Note that
the scalars plugin loads. Start TensorBoard pointed at the PR curves
demo data. The scalars plugin is inactive.
Use
time.time()to log the time it takes for some internal events file(with over 30K tags in one specific run) with and without this change.
With this change, the is_active method takes 0.0s to complete. Without this
change, it takes 12.0s. Sometimes, the frontend won't load because
is_activetakes too long to respond.Granted, one might reason that a user should not have 30K tags ... but
even so, that should not block the rest of TensorBoard from loading.