Fix broken Angular dashboards in need of localization module #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psybuzz
changed the title
stephanwlee
reviewed
May 5, 2021
tensorboard/webapp/app_module.ts
Outdated
| // Angular 9+ using Ivy apps that potentially do i18n, even transitively, must | ||
| // import this module, which adds a global symbol at runtime. | ||
| // https://angular.io/guide/migration-localize | ||
| import '@angular/localize/init' |
There was a problem hiding this comment.
Please move this to main_prod.ts. It is already included in the main_dev.ts so feel free to refactor and move them to bootstrap.ts.
stephanwlee
approved these changes
May 5, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular component-based dashboards currently fail to render. The
JS error at runtime points to the lack of an import of Angular's new
"localize" module, required for applications using Ivy and Angular 9+.
See https://angular.io/guide/migration-localize for details.
Note that the
//tensorboard:devtarget is fine. For some reason,only the "prod" target
//tensorboardis affected.Manually tested by running
bazel run tensorboard -- --logdir logs --bind_all, opening the 'Time Series' dashboard, and seeing the panel appear.Googlers, see test sync cl/372052576