plugin_util: use thread-local Markdown converter #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In #3348, we centralized a shared Markdown converter rather than creating a new one for each call. But this had the effect of sharing the converter across threads, which is not supported, as the [API docs helpfully note][1]. This commit splits the globally shared converter into separate thread-local converters. [1]: https://python-markdown.github.io/reference/#Markdown Test Plan: Prior to this change, some requests would 500 due to internal errors in the Markdown converter: ``` File ".../markdown/treeprocessors.py", line 187, in __processPlaceholders for child in [node] + list(node): TypeError: 'NoneType' object is not iterable ``` This was always nondeterministic, but I haven’t been able to reproduce it with this patch, even hammering the dashboard with a bunch of Chrome tabs or `curl` requests. wchargin-branch: threadlocal-markdown-converter
Merged
bileschi
pushed a commit
to bileschi/tensorboard
that referenced
this pull request
Apr 15, 2020
Summary: In tensorflow#3348, we centralized a shared Markdown converter rather than creating a new one for each call. But this had the effect of sharing the converter across threads, which is not supported, as the [API docs helpfully note][1]. This commit splits the globally shared converter into separate thread-local converters. [1]: https://python-markdown.github.io/reference/#Markdown Test Plan: Prior to this change, some requests would 500 due to internal errors in the Markdown converter: ``` File ".../markdown/treeprocessors.py", line 187, in __processPlaceholders for child in [node] + list(node): TypeError: 'NoneType' object is not iterable ``` This was always nondeterministic, but I haven’t been able to reproduce it with this patch, even hammering the dashboard with a bunch of Chrome tabs or `curl` requests. wchargin-branch: threadlocal-markdown-converter
bileschi
pushed a commit
that referenced
this pull request
Apr 15, 2020
Summary: In #3348, we centralized a shared Markdown converter rather than creating a new one for each call. But this had the effect of sharing the converter across threads, which is not supported, as the [API docs helpfully note][1]. This commit splits the globally shared converter into separate thread-local converters. [1]: https://python-markdown.github.io/reference/#Markdown Test Plan: Prior to this change, some requests would 500 due to internal errors in the Markdown converter: ``` File ".../markdown/treeprocessors.py", line 187, in __processPlaceholders for child in [node] + list(node): TypeError: 'NoneType' object is not iterable ``` This was always nondeterministic, but I haven’t been able to reproduce it with this patch, even hammering the dashboard with a bunch of Chrome tabs or `curl` requests. wchargin-branch: threadlocal-markdown-converter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #3348, we centralized a shared Markdown converter rather than
creating a new one for each call. But this had the effect of sharing the
converter across threads, which is not supported, as the API docs
helpfully note. This commit splits the globally shared converter
into separate thread-local converters.
Test Plan:
Prior to this change, some requests would 500 due to internal errors in
the Markdown converter:
This was always nondeterministic, but I haven’t been able to reproduce
it with this patch, even hammering the dashboard with a bunch of Chrome
tabs or
curlrequests.wchargin-branch: threadlocal-markdown-converter