core: split magic --logdir_spec
out from verbatim --logdir
#2664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This introduces a new flag,
--logdir_spec
, whose behavior is the sameas the old behavior of
--logdir
. The--logdir
flag now specifies asingle log directory, without special treatment for commas and colons,
though it still has the
expanduser
call for compatibility with userswho use the
--logdir=~/...
form rather than--logdir ~/...
.I audited all uses of
flags.logdir
andcontext.logdir
, and, otherthan those changed in this commit, all really should be using
logdir
rather than
logdir_spec
(i.e., they do not properly parse the logdirspec, and so were broken before this commit).
Fixes #2615, fixes #1220, and fixes lots of user confusion.
Test Plan:
Run with the following args:
wchargin-branch: logdir-spec