Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in PluginEventAccumulator.PluginTagToContent() #1235

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

nfelt
Copy link
Contributor

@nfelt nfelt commented Jun 10, 2018

...by returning a copy of the underlying tag-to-content dict for that plugin, and using a set of per-plugin locks to protect against simultaneous addition of keys to that dict.

Fixes #1201.

@nfelt nfelt requested a review from jart June 10, 2018 22:27
Copy link
Contributor

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@nfelt
Copy link
Contributor Author

nfelt commented Jun 11, 2018

Thanks!

@nfelt nfelt merged commit f286cec into tensorflow:master Jun 11, 2018
@nfelt nfelt deleted the accumulator-tag-race branch June 11, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants