Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing event file spec in Windows #265

Closed
shakedel opened this issue Jul 25, 2017 · 1 comment
Closed

Parsing event file spec in Windows #265

shakedel opened this issue Jul 25, 2017 · 1 comment
Labels
os:windows

Comments

@shakedel
Copy link
Contributor

In backend.application.parse_event_files_spec a log directory 'spec' is partitioned with respect to : (line 267) to allow the run_name:path expression. However, this handicaps Windows user with log directories residing on other drives, e.g. D:\ as the path is split (without using the run_name exp). using os.path.splitdrive can solve this, but only if we limit the run_name to be longer than 1 letter.
@shakedel shakedel mentioned this issue Jul 25, 2017
Merged
@wchargin
Copy link
Contributor

Thanks for your PR! Closing this issue as a duplicate of #52, but we'll of course still take a look at the PR.

@wchargin wchargin marked this as a duplicate of #52 Jul 25, 2017
teamdandelion pushed a commit that referenced this issue Oct 10, 2017
@shakedel @teamdandelion
fix for issue #265 (#266)
55524a6 
* fix for issue #265

* added tests for issue #52 fix

* minor changes due to PR #266 comments

* removed lines exceeding 80 chars in application.py and application_test.py

* added wrapped lines indentation to satisfy pylint

* minor indentation fix

* adapted unittest.mock import to python version 2.7

* another minor indentation fix
@nfelt nfelt mentioned this issue Feb 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os:windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wchargin @shakedel