Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nondeterminism in text_plugin_test #1072

Closed
jart opened this issue Mar 23, 2018 · 1 comment · Fixed by #1078
Closed

Nondeterminism in text_plugin_test #1072

jart opened this issue Mar 23, 2018 · 1 comment · Fixed by #1078
Assignees
Labels

Comments

@jart
Copy link
Contributor

jart commented Mar 23, 2018

#1021 introduced a test regression, likely caused by the hash map dict.keys() method introducing nondeterministic order.

======================================================================
FAIL: testPluginTagsImpl (__main__.TextPluginTest)
testPluginTagsImpl (__main__.TextPluginTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tensorboard/plugins/text/text_plugin_test.py", line 404, in testPluginTagsImpl
    }, self.plugin.tags_impl())
AssertionError: {'fry': ['message', 'vector'], 'leela': ['message', 'vector']} != {'fry': [u'vector', u'message'], 'leela': [u'vector', u'message']}
repr() of differing entries:
'fry': ['message', 'vector'] != [u'vector', u'message']
'leela': ['message', 'vector'] != [u'vector', u'message']

I'm going to workaround this internally. This test should be fixed.

However I suspect this might be the tip of the iceberg with the multiplexer and accumulator. I'd very much like for us to move in a direction where our serving endpoints are deterministic, and not impacted by underlying hashing algorithms. SQL should help.

@chihuahua
Copy link
Member

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants