Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projector: add notebook renderer #187

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

stephanwlee
Copy link
Collaborator

This change introduces Python API to render the new projector in Juypter
notebook. It currently provides work in progress API, embedding which
visualizes the embedding data and label rendered in the visualization.

In order to support both Colab and Jupyter, I have decided to introduce
an abstraction, Renderer which knows how to render an output cell and
how to communicate with it. Do note that Jupyter and Colab are very
different; Jupyter does not encapsulate JavaScript context for each
output cell so a symbol exposed on globalThis bleeds over to other
output cells while Colab does not do that.

This change introduces Python API to render the new projector in Juypter
notebook. It currently provides work in progress API, `embedding` which
visualizes the embedding data and label rendered in the visualization.

In order to support both Colab and Jupyter, I have decided to introduce
an abstraction, `renderer` which knows how to render an output cell and
how to communicate with it. Do note that Jupyter and Colab are very
different; Jupyter does not encapsulate JavaScript context for each
output cell so a symbol exposed on `globalThis` bleeds over to other
output cells while Colab does not do that.
@owenvallis
Copy link
Collaborator

I think were just missing some type annotations. Looks like the static typing tests are failing for tensorflow_similarity/visualization/projector_v2/notebook.py:71

@stephanwlee
Copy link
Collaborator Author

Thanks for taking a look at the CI. I am doing the work on the side and will get to it when ready. Also, will mark the PR as "Ready for review" when it is truly ready.

@owenvallis
Copy link
Collaborator

Sounds good, thanks!

owenvallis added a commit that referenced this pull request Jul 12, 2022
Moved the projector_v2 code to a separate branch until PR #187 is ready.
abeltheo pushed a commit to abeltheo/similarity that referenced this pull request Mar 23, 2023
Moved the projector_v2 code to a separate branch until PR tensorflow#187 is ready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants