Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TripletLoss example #360

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Conversation

seanpmorgan
Copy link
Member

Closes #334

@seanpmorgan seanpmorgan requested a review from a team as a code owner July 18, 2019 20:22
@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/addons/pull/360

You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB.

@@ -0,0 +1,374 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the new tfa loss


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks! I've removed the line

@@ -0,0 +1,374 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clusters look great! Maybe showing the class for each cluster would be much better!


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. It's a bit difficult to do in the projector. Let me know if the updated image works.

@WindQAQ
Copy link
Member

WindQAQ commented Jul 21, 2019

Hmm, seems ReviewNB is probably not a great tool to show the comments in GitHub...

@seanpmorgan
Copy link
Member Author

Hmm, seems ReviewNB is probably not a great tool to show the comments in GitHub...

Yeah not great, but I just read comments in the ReviewNB webpage. Please check out the changes when you have time

Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@WindQAQ WindQAQ merged commit 762bd1d into tensorflow:master Jul 22, 2019
@seanpmorgan seanpmorgan deleted the example-tripletloss branch July 29, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for example: Triplet Loss
3 participants