-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TripletLoss example #360
TripletLoss example #360
Conversation
Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/addons/pull/360 You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB. |
@@ -0,0 +1,374 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch thanks! I've removed the line
@@ -0,0 +1,374 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clusters look great! Maybe showing the class for each cluster would be much better!
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. It's a bit difficult to do in the projector. Let me know if the updated image works.
Hmm, seems ReviewNB is probably not a great tool to show the comments in GitHub... |
Yeah not great, but I just read comments in the ReviewNB webpage. Please check out the changes when you have time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Closes #334