Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate npairs_loss #309

Merged
merged 7 commits into from
Jun 21, 2019
Merged

Migrate npairs_loss #309

merged 7 commits into from
Jun 21, 2019

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Jun 20, 2019

Addresses #26. Will proceed with multilabel npairs loss after this.

@WindQAQ WindQAQ added the losses label Jun 20, 2019
@WindQAQ WindQAQ requested a review from a team June 20, 2019 07:00
@WindQAQ WindQAQ requested a review from facaiy as a code owner June 20, 2019 07:00
@WindQAQ WindQAQ removed the request for review from facaiy June 20, 2019 07:01
Squadrick
Squadrick suggested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes.

tensorflow_addons/losses/npairs.py Outdated Show resolved Hide resolved
tensorflow_addons/losses/npairs.py Outdated Show resolved Hide resolved
tensorflow_addons/losses/npairs.py Outdated Show resolved Hide resolved
Squadrick
Squadrick approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM.

@Squadrick Squadrick merged commit 7a1ed4b into tensorflow:master Jun 21, 2019
@WindQAQ WindQAQ deleted the migrate-npairs-loss branch June 21, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Squadrick Squadrick Squadrick approved these changes

Assignees
No one assigned
Labels
cla: yes losses
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WindQAQ @Squadrick @googlebot