Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the CRF model wrapper #2555

Merged
merged 5 commits into from
Oct 1, 2021

Conversation

howl-anderson
Copy link
Contributor

Description

Brief Description of the PR:

Add the CRF model wrapper.

It can be used like following:

tag_num = ... # number of tags
base_model = build_base_model(...)
model = CRFModelWraper(base_model, tag_num)

# CRFModelWraper is a subclass of tf.keras.Model
# so we can compile / fit / evaluate as normal model

# NOTE: CRF loss is computed inside the model, so we do not specific the loss for crf
model.compile(...)
model.fit(...)

Fixes # (issue)

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@google-cla google-cla bot added the cla: yes label Sep 2, 2021
@howl-anderson
Copy link
Contributor Author

@gabrieldemarmiesse You are one of the most suitable reviewers for this PR. So please take a look. Thank you!

@howl-anderson howl-anderson changed the title [WIP] Add the CRF model wrapper Add the CRF model wrapper Sep 6, 2021
@howl-anderson howl-anderson mentioned this pull request Sep 6, 2021
21 tasks
@bhack
Copy link
Contributor

bhack commented Sep 15, 2021

@gabrieldemarmiesse You are one of the most suitable reviewers for this PR. So please take a look. Thank you!

I don't think he is still active in the project.

@howl-anderson
Copy link
Contributor Author

@bhack Thank you for your kindly remind. Do you have any reviewer to recommend for this PR? Or could it possible to grant write permission to me? So, I can merge it to the repo. There are a few CRF related PRs still waiting for review for more than two weeks but no one response yet. If I have the write permission, I can merge them too. Of course, I am the codeower of those CRF related features, so I will continuously bugfix and improve them.

/cc @seanpmorgan

@bhack bhack merged commit 8e73b9d into tensorflow:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants