Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of streaming Kendall's Tau algorithm. #2423

Merged
merged 6 commits into from
Apr 9, 2021

Conversation

sorensenjs
Copy link
Contributor

@sorensenjs sorensenjs commented Mar 23, 2021

Description

Brief Description of the PR:
Introduces a streaming Kendall's Tau metric implementation.

Fixes # (issue)

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

tensorflow_addons/metrics/kendalls_tau.py Outdated Show resolved Hide resolved
tensorflow_addons/metrics/kendalls_tau.py Outdated Show resolved Hide resolved
tensorflow_addons/metrics/kendalls_tau.py Outdated Show resolved Hide resolved
tensorflow_addons/metrics/kendalls_tau.py Show resolved Hide resolved
tensorflow_addons/metrics/tests/kendall_tau_test.py Outdated Show resolved Hide resolved
Remove debuging prints, fix typos.
bhack
bhack previously approved these changes Apr 9, 2021
@bhack
Copy link
Contributor

bhack commented Apr 9, 2021

Just a final edit, can you add yourself in https://github.com/tensorflow/addons/blob/master/.github/CODEOWNERS for this?

bhack
bhack previously approved these changes Apr 9, 2021
@sorensenjs sorensenjs requested a review from bhack April 9, 2021 20:14
@bhack bhack merged commit 30c8a70 into tensorflow:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants