Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building against CUDA 11 and CUDNN 8 #1950

Merged
merged 4 commits into from
Jul 10, 2020

Conversation

nluehr
Copy link
Contributor

@nluehr nluehr commented Jun 25, 2020

No description provided.

@seanpmorgan
Copy link
Member

No description provided.

Thanks for the PR! Quick glance looks great, but needs some formatting. I'm going to have substantial amount of time to devote to Addons in the near future and will make sure I get to this PR review if it's not done within a week or so.

@seanpmorgan seanpmorgan self-assigned this Jun 25, 2020
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks! Tested and addons compiles correctly. I'm not going to close #770 since I still want to investigate symbol mismatches with TF compiled with matching CUDA versions

@seanpmorgan seanpmorgan merged commit f438fb7 into tensorflow:master Jul 10, 2020
ashutosh1919 pushed a commit to ashutosh1919/addons that referenced this pull request Jul 12, 2020
* Support building against CUDA 11 and CUDNN 8

* Fix formatting

* Fix formatting in cuda_configure.bzl

* Fix flake8 E741 errors in some tests
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
* Support building against CUDA 11 and CUDNN 8

* Fix formatting

* Fix formatting in cuda_configure.bzl

* Fix flake8 E741 errors in some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants