Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added layer_test in addons and refactoring the code #1715

Closed
wants to merge 6 commits into from

Conversation

ashutosh1919
Copy link
Contributor

We need to modify code in many files to resolve issue #1567 .
This PR adds layer_test in testing_utils of addons.
@gabrieldemarmiesse - I have removed all codes in the function corresponding to model checking and set|get_weights(). Currently, tests will fail because the method doesn't return anything (previously it was returning something like actual_output which was part of Sequential API tests part.). Please review the code and guide me to the right direction.

@gabrieldemarmiesse
Copy link
Member

  • We don't need a model for the tests but we still need to do a foward pass to ensure that no exception is raised. To get the output values just do output_tensor = layer(input_tensor).numpy(). So we can still return the result without using a keras model.

  • Another thing to check is that the layer output the same numbers after being serialized and deserialized.

@ashutosh1919
Copy link
Contributor Author

@gabrieldemarmiesse , I have added codes as per you comment. But still many tests fails. Tests fails because of lib NotFoundError. Please can you take a look and give me a hint?

Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to use a keras model here. Can you try that and see if the NotFoundError is still there? Thanks a lot

tensorflow_addons/utils/test_utils.py Outdated Show resolved Hide resolved
@gabrieldemarmiesse gabrieldemarmiesse removed their assignment Jun 1, 2020
@ashutosh1919
Copy link
Contributor Author

cc @bhack

@seanpmorgan
Copy link
Member

Thank you for your contribution. We sincerely apologize for any delay in reviewing, but TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP

@seanpmorgan seanpmorgan closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants