Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude_from_weight_decay in RectifiedAdam() #2681

Closed
markub3327 opened this issue Mar 7, 2022 · 5 comments
Closed

exclude_from_weight_decay in RectifiedAdam() #2681

markub3327 opened this issue Mar 7, 2022 · 5 comments

Comments

@markub3327
Copy link
Contributor

Describe the feature and the current behavior/state.

Can RectifiedAdam have same parameter exclude_from_weight_decay as AdamW? We must exclude some parameters of the model from weight decay.

Relevant information

  • Are you willing to contribute it (yes/no): yes
    If you wish to contribute, then read the requirements for new contributions in CONTRIBUTING.md
  • Are you willing to maintain it going forward? (yes/no): yes
  • Is there a relevant academic paper? (if so, where): no
  • Does the relavent academic paper exceed 50 citations? (yes/no): no
  • Is there already an implementation in another framework? (if so, where): yes
  • Was it part of tf.contrib? (if so, where): No

Which API type would this fall under (layer, metric, optimizer, etc.)

optimizer

Who will benefit with this feature?

Everyone

Any other info.

Thanks a lot.

@bhack
Copy link
Contributor

bhack commented Mar 8, 2022

Probably this component is orphan.
Gently ping @szutenberg

@markub3327 Can you check with a ticket on https://github.com/keras-team/keras if they are interested if you port this in Keras with your exclude_from_weight_decay extension?

@markub3327
Copy link
Contributor Author

@bhack The ticket is done.

@bhack
Copy link
Contributor

bhack commented Mar 8, 2022

Thank you as AdamW was just duplicated there 27 days ago probably you could add a comment there also for exclude_from_weight_decay for AdamW

@markub3327
Copy link
Contributor Author

@bhack I have done it.

Please look here.

@seanpmorgan
Copy link
Member

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants