Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CorrelationCost1D #1907

Closed
serizba opened this issue Jun 2, 2020 · 2 comments
Closed

Support for CorrelationCost1D #1907

serizba opened this issue Jun 2, 2020 · 2 comments
Labels
Feature Request help wanted Needs help as a contribution layers

Comments

@serizba
Copy link

serizba commented Jun 2, 2020

Describe the feature and the current behavior/state.
Support for CorrelationCost along just 1 dimension. Currently CorrelationCost applies the kernel in both directions, horizontal and vertical, as described in the original FlowNet paper. When working with rectified stereo images, you may only need to compute the correlation cost in horizontal lines, as done in DispNet.

Relevant information

  • Are you willing to contribute it (yes/no): No
  • Are you willing to maintain it going forward? (yes/no): No
  • Is there a relevant academic paper? (if so, where): DispNet
  • Is there already an implementation in another framework? (if so, where): lmbspecialops repository Repository with different operations used in FlowNet, DispNet and others.
  • Was it part of tf.contrib? (if so, where): No

Which API type would this fall under (layer, metric, optimizer, etc.)
It should be a layer as CorrelationCost
Who will benefit with this feature?
Researchers working with rectified stereo images where the information should only be searched along horizontal lines.

@seanpmorgan seanpmorgan added Feature Request layers help wanted Needs help as a contribution labels Jun 3, 2020
@chekoduadarsh
Copy link

@seanpmorgan

Hey, I would like to implement this feature. (This is my first time contributing to Tensorflow) Could you assign this to me?

@seanpmorgan
Copy link
Member

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request help wanted Needs help as a contribution layers
Projects
None yet
Development

No branches or pull requests

3 participants