This repository has been archived by the owner on May 26, 2023. It is now read-only.
Fix workflows page not properly filtering workflows #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Jul 14, 2020
| @@ -130,12 +130,15 @@ export default pagedGrid({ | |||
| statuses: [ | |||
| { value: 'OPEN', label: 'Open' }, | |||
There was a problem hiding this comment.
I would rename this to RUNNING for consistency with WORKFLOW_EXECUTION_STATUS_RUNNING (if it makes sense).
There was a problem hiding this comment.
in general I agree, in this case we should also update the API and remove explicit ListOpenWorkflowExecutions command (as well as ListClosedWorkflowExecutions ). Instead unify into a single endpoint ListWorkflowExecutions with a status param
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57 Workflows page status dropdown not filtering workflows properly bug