Data encoder config #429
Data encoder config #429
Conversation
Later this will probably be adjusted to point to a central docs page that explains the full setup, including security implications.
|
Updated to latest protocol so now relies on: temporalio/sdk-go#733 |
| } | ||
|
|
||
| requests.push( | ||
| fetch(`${endpoint}/decode`, { method: 'POST', headers: headers, body: JSON.stringify(payloadsWrapper) }) |
There was a problem hiding this comment.
Just a thought we should make sure wherever this is happening has http2.1 otherwise we'll only be able to decode 8 things at a time which would severely block rendering.
There was a problem hiding this comment.
The server aspect will be up to the users, it's not something we control. We can document that it should support http2 though.
There was a problem hiding this comment.
I think that data encoder is a better name (and I think makes it easier to talk about) but we should double check our docs to ensure that we're not shooting ourselves in the foot for confusion with our users. If we do decide to do that we should loop docs in to update some pages as well.
|
Yep, I'll be working on the docs for all this and will make sure the difference is clear between Data Converter and Remote Encoder. |
* Wire up remote data encoder config. * Update to latest remote decoder protocol.
What was changed
Refactored the remote data encoder code a little to be more consistent with terms. Also added some documentation around the setup of such a system, although this should be improved and centralised later.
Why?
This allows users to configure a remote data encoder endpoint globally for the Temporal Web instance rather than relying on per-session settings as was previously the case. Given remote data encoders will be deployed and shared it does not make sense to require per-session settings for every user.
Checklist
How was this tested:
Tested using my background-checks integration branch.
Any docs updates needed?
Yes, docs will need to involve as more SDKs add support for remote data encoding and we add a central page that documents the setup as a whole.