Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Add server security notion in readme and remove Google OIDC notion #412

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Add server security notion in readme and remove Google OIDC notion #412

merged 5 commits into from
Nov 10, 2021

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Nov 10, 2021 •
edited
Loading

What was changed

  • Added server security notion and a link to the security docs
  • Switched to Auth0 as sample values for OIDC auth instead of Google
  • Removed authentication beta notion from readme

Why?

  • users would enable auth on the Web though wouldn't add JWT tokens validation on the server side, having a wrong impressions of secured setup
  • Google OIDC for base @google.com accounts doesn't seem to have/make it easy to configure permissions. Preferred Auth0 as samples

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@feedmeapples feedmeapples changed the title Remove Google OIDC example from readme Add server security notion in readme and remove Google OIDC example Nov 10, 2021
@feedmeapples feedmeapples changed the title Add server security notion in readme and remove Google OIDC example Add server security notion in readme and remove Google OIDC notion Nov 10, 2021
@swyxio swyxio merged commit ca1b289 into master Nov 10, 2021
@swyxio swyxio deleted the remove-google-oidc-readme branch November 10, 2021 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevekinney stevekinney stevekinney approved these changes

@swyxio swyxio swyxio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feedmeapples @stevekinney @swyxio