Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Show no stack trace available message for complete workflows #360

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

feedmeapples
Copy link
Contributor

What was changed

Added No Stack Trace available message if workflow is not running
image

Why?

Clear message instead of empty stack trace

Additionally if there are Workers running:

  • prevents unnecessarily pending for stack trace if workflow is ~complete and immediately let's user know stack trace is not available. (pending was taking many seconds until context would deadline and error message show up)

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@feedmeapples feedmeapples force-pushed the stack-trace-not-available-message branch from 8a7bf04 to e90a3e7 Compare July 9, 2021 23:31
@feedmeapples feedmeapples force-pushed the stack-trace-not-available-message branch from e90a3e7 to 967141e Compare July 9, 2021 23:33
@feedmeapples feedmeapples force-pushed the stack-trace-not-available-message branch from 967141e to b929f21 Compare July 10, 2021 00:14
@swyxio swyxio merged commit 5bef5bf into master Jul 10, 2021
@swyxio swyxio deleted the stack-trace-not-available-message branch July 10, 2021 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants