This repository has been archived by the owner on May 26, 2023. It is now read-only.
Minimize payloads processing failure impact #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
changed the title
feedmeapples
force-pushed
the
trycatch-payloads
branch
from
37bc732
to
cab5367
Compare
swyxio
approved these changes
May 19, 2021
feedmeapples
force-pushed
the
trycatch-payloads
branch
from
cab5367
to
4e9b900
Compare
feedmeapples
force-pushed
the
trycatch-payloads
branch
from
4e9b900
to
f2da5ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a trycatch block for payloads processing
Added logging if processing fails
Why?
To cover an unexpected case if payload is not being serialized to json, make it easier to debug, still show the rest of UI (history events etc).
Checklist
Closes issue:
How was this tested:
Using openNClosed samples fixture + bench tests data. Lastly cicd (to be tested)
No