This repository has been archived by the owner on May 26, 2023. It is now read-only.
Add readme sample for web root path variable #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adds readme sample of
TEMPORAL_WEB_ROOT_PATH
valueWhy?
Web root path works only if passed in a format with forward slashes on both sides. This value is passed to koa-router, webpack and used in http.js.
Another option would be to do custom processing and modify the value so it fits the format.
The below regex can be used to trim forward slashes on both ends of the path. Then the resulting value can be passed to koa-router, webpack and http.js according to their expected format (adding forward slashes if needed). Having slashes on both sides works for all places
Checklist
Closes issue:
How was this tested:
Ran with
TEMPORAL_WEB_ROOT_PATH
set to"/test/"
No